jnh5y commented on code in PR #21133:
URL: https://github.com/apache/flink/pull/21133#discussion_r1021869458
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java:
##########
@@ -311,8 +340,29 @@ public GatewayInfo getGatewayInfo() {
return GatewayInfo.INSTANCE;
}
+ //
--------------------------------------------------------------------------------------------
+
@VisibleForTesting
public Session getSession(SessionHandle sessionHandle) {
return sessionManager.getSession(sessionHandle);
}
+
+ /** Fetch all results for configuring session. */
+ private ResultSet fetchConfigureSessionResult(
+ SessionHandle sessionHandle, OperationHandle operationHandle) {
+ ResultSet firstResult = fetchResults(sessionHandle, operationHandle,
0, Integer.MAX_VALUE);
+ while (firstResult == ResultSet.NOT_READY_RESULTS) {
+ firstResult = fetchResults(sessionHandle, operationHandle, 0,
Integer.MAX_VALUE);
Review Comment:
It seems like operations like AddJar could be synchronous and take some
period of time, right?
If that's the case, this will be a busy wait on any synchronous operations
which take time, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
