[
https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529764#comment-15529764
]
ASF GitHub Bot commented on FLINK-4329:
---------------------------------------
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2546
Just a quick comment (I didn't review all code): Why does this touch the
AlignedWindowOperator tests? I would like to keep this commit as small as
possible because we're dealing with sensitive stuff where I'd like to clearly
separate things.
In `OneInputStreamOperatorTestHarness` and
`KeyedOneInputStreamOperatorTestHarness`, restricting the time provider
parameter to a `TestTimeServiceProvider` does not change anything, right? So I
think we can leave it as is. Also in `OneInputStreamOperatorTestHarness` the
additional `TimeCharacteristic` parameter is only useful for one specific test
so I think it would be better to instead expose the `StreamConfig` and set the
parameter there for the one test to keep the number of constructors manageable.
> Fix Streaming File Source Timestamps/Watermarks Handling
> --------------------------------------------------------
>
> Key: FLINK-4329
> URL: https://issues.apache.org/jira/browse/FLINK-4329
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Aljoscha Krettek
> Assignee: Kostas Kloudas
> Fix For: 1.2.0, 1.1.3
>
>
> The {{ContinuousFileReaderOperator}} does not correctly deal with watermarks,
> i.e. they are just passed through. This means that when the
> {{ContinuousFileMonitoringFunction}} closes and emits a {{Long.MAX_VALUE}}
> that watermark can "overtake" the records that are to be emitted in the
> {{ContinuousFileReaderOperator}}. Together with the new "allowed lateness"
> setting in window operator this can lead to elements being dropped as late.
> Also, {{ContinuousFileReaderOperator}} does not correctly assign ingestion
> timestamps since it is not technically a source but looks like one to the
> user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
