zentol commented on code in PR #20070:
URL: https://github.com/apache/flink/pull/20070#discussion_r1022540462
##########
tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/utils/shade/ShadeParser.java:
##########
@@ -46,7 +46,6 @@ public final class ShadeParser {
+ "(?<groupId>.*?):"
+ "(?<artifactId>.*?):"
+ "(?<type>.*?):"
- + "(?:(?<classifier>.*?):)?"
Review Comment:
Had to roll-back this addition to keep the behavior in sync with the
NoticeParser, which currently doesn't account for classifiers and just parses
them as part of the version.
Will be fixed in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
