gyfora commented on code in PR #420:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1023713735
##########
helm/flink-kubernetes-operator/templates/webhook.yaml:
##########
@@ -85,7 +85,7 @@ metadata:
cert-manager.io/inject-ca-from: {{ .Release.Namespace
}}/flink-operator-serving-cert
name: flink-operator-{{ .Release.Namespace }}-webhook-configuration
webhooks:
-- name: flinkoperator.flink.apache.org
+- name: validationwebhook.flink.apache.org
Review Comment:
Do you mean the validating and the mutating webhook name clashes?
##########
helm/flink-kubernetes-operator/templates/webhook.yaml:
##########
@@ -85,7 +85,7 @@ metadata:
cert-manager.io/inject-ca-from: {{ .Release.Namespace
}}/flink-operator-serving-cert
name: flink-operator-{{ .Release.Namespace }}-webhook-configuration
webhooks:
-- name: flinkoperator.flink.apache.org
+- name: validationwebhook.flink.apache.org
Review Comment:
If so, why not change both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
