tagarr commented on code in PR #420:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024106606
##########
flink-kubernetes-webhook/pom.xml:
##########
@@ -96,6 +96,12 @@ under the License.
<version>${okhttp.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
Review Comment:
@morhidi Understand, I looked at using
https://junit-pioneer.org/docs/environment-variables/ which has some nice
capabilities to change system env vars, but noticed when running it I get `This
extension uses reflection to mutate JDK-internal state, which is fragile`
warnings when running in intellij. Do you think it would be ok to add a method
to EnvUtils e.g. setEnvironment(Map env) and use this to override System env
vars ? Or can you think of something better ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
