[GitHub] [flink-table-store] zjureel commented on a diff in pull request #383: [FLINK-30033] Add primary key type validation

[GitBox]

zjureel commented on code in PR #383:
URL: https://github.com/apache/flink-table-store/pull/383#discussion_r1024730773


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java:
##########
@@ -157,6 +159,33 @@ public TableSchema commitNewVersion(UpdateSchema 
updateSchema) throws Exception
         }
     }
 
+    private void validatePrimaryKeysType(UpdateSchema updateSchema, 
List<String> primaryKeys) {
+        if (!primaryKeys.isEmpty()) {
+            Map<String, RowType.RowField> rowFields = new HashMap<>();
+            for (RowType.RowField rowField : 
updateSchema.rowType().getFields()) {
+                rowFields.put(StringUtils.lowerCase(rowField.getName()), 
rowField);

Review Comment:
   I will try to fix it later
   
   > I created a jira for hive https://issues.apache.org/jira/browse/FLINK-29988
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org