[ https://issues.apache.org/jira/browse/FLINK-29944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635246#comment-17635246 ]
Xintong Song commented on FLINK-29944: -------------------------------------- Agree with [~luoyuxia]. [~hk__lrzy], We are aware that the new source is from FLIP-27. However, the two public interfaces you are trying to add are not part of FLIP-27, which has been voted on. Any new changes to the public interface would need to go through the FLIP process. Please see the following instructions for starting a FLIP. https://flink.apache.org/contributing/contribute-code.html https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals > Support accumulator in source reader > ------------------------------------ > > Key: FLINK-29944 > URL: https://issues.apache.org/jira/browse/FLINK-29944 > Project: Flink > Issue Type: Improvement > Components: API / DataStream > Affects Versions: 1.17.0 > Reporter: hk__lrzy > Priority: Critical > Labels: pull-request-available > > Source Reader is mainly for union batch and streaming logic in single > interface, it's good point for the developer, but in the {{SourceFunction}} > we can access {{runtimeconext}} to use accumulator before, now the > {{SourceReaderContext}} have no method for it, this PR is mainly to support > it. -- This message was sent by Atlassian Jira (v8.20.10#820010)