gaborgsomogyi commented on PR #21128: URL: https://github.com/apache/flink/pull/21128#issuecomment-1318699210
@MartijnVisser I was digging why the YARN tests are failing and I think I've found one issue :) Namely I have the feeling that the [following](https://github.com/apache/flink/blob/ba4b182955867fedfa9891bf0bf430e92eeab41a/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java#L1214-L1233) code is not executed. This would solve issues like this: ``` 2022-11-16T00:25:48.6832701Z Nov 16 00:25:48 java.lang.AssertionError: 2022-11-16T00:25:48.6833089Z Nov 16 00:25:48 2022-11-16T00:25:48.6833483Z Nov 16 00:25:48 Expecting file: 2022-11-16T00:25:48.6835321Z Nov 16 00:25:48 /__w/1/s/flink-yarn-tests/target/flink-yarn-tests-capacityscheduler 2022-11-16T00:25:48.6836232Z Nov 16 00:25:48 to exist. ``` Do we have `IS_CI=true` on CI? I don't know the background story of this env var but I've the feeling that it's designed out but some places we still have this garbage. In general I think we must avoid such things because it ends-up in different execution path between local and CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
