JingsongLi commented on code in PR #388:
URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026090480
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FlinkSourceBuilder.java:
##########
@@ -150,20 +153,20 @@ private FileStoreSource buildFileSource(boolean
isContinuous, boolean continuous
LogStartupMode startupMode = conf.get(LOG_SCAN);
if (logSourceProvider == null) {
- return buildFileSource(true, startupMode ==
LogStartupMode.LATEST);
+ return buildFileSource(true, startupMode,
conf.get(LOG_SCAN_TIMESTAMP_MILLS));
} else {
if (startupMode != LogStartupMode.FULL) {
return logSourceProvider.createSource(null);
}
return HybridSource.<RowData,
StaticFileStoreSplitEnumerator>builder(
- buildFileSource(false, false))
+ buildFileSource(false, startupMode, null))
.addSource(
new LogHybridSourceFactory(logSourceProvider),
Boundedness.CONTINUOUS_UNBOUNDED)
.build();
}
} else {
- return buildFileSource(false, false);
+ return buildFileSource(false, LogStartupMode.FULL, null);
Review Comment:
Here should ignore it. `log.scan` should not affect batch mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
