zentol commented on code in PR #21344:
URL: https://github.com/apache/flink/pull/21344#discussion_r1026171420


##########
pom.xml:
##########
@@ -991,7 +991,7 @@ under the License.
                                                <plugin>
                                                        
<groupId>org.apache.maven.plugins</groupId>
                                                        
<artifactId>maven-shade-plugin</artifactId>
-                                                       <version>3.2.4</version>
+                                                       <version>3.4.0</version>

Review Comment:
   a) Why not 3.4.1?
   b) Why make this specific to Java 11? We should try upgrading it in the 
default configuration (since you're trying to fix a general build issue) and (I 
guess) get rid of the java11-specific configuration (since it's subsumed).
   
   FYI, 3.4.1 also fixes FLINK-20092 from some brief testing another person did.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to