[ 
https://issues.apache.org/jira/browse/FLINK-29072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636404#comment-17636404
 ] 

Yubin Li commented on FLINK-29072:
----------------------------------

Hi, [~qingyue] [~luoyuxia], I have implemented the feature in 
https://issues.apache.org/jira/browse/FLINK-29679, it support all flink tables 
including hive connector, now ci has passed and column comment displayed, would 
you please give a review?

> Migrate DDL-related schema handling to the new Schema framework
> ---------------------------------------------------------------
>
>                 Key: FLINK-29072
>                 URL: https://issues.apache.org/jira/browse/FLINK-29072
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Table SQL / API
>    Affects Versions: 1.16.0
>            Reporter: Jane Chan
>            Priority: Major
>
> [FLIP-164|https://cwiki.apache.org/confluence/display/FLINK/FLIP-164%3A+Improve+Schema+Handling+in+Catalogs]
>  introduces the new Schema framework. Yet all DDL-related functionalities 
> (such as CREATE TABLE, CREATE TABLE LIKE, ALTER TABLE SET/RESET, ALTER TABLE 
> ADD/DROP CONSTRAINT, SHOW CREATE TABLE, etc.) are based on the deprecated 
> CatalogTableImpl and TableSchema.
> The FLIP said, "For backward compatibility, we leave Catalog#createTable and 
> Catalog#alterTable untouched." Therefore, issues like FLINK-18958, 
> FLINK-28690, etc., cannot be resolved. And new functionalities like ALTER 
> TABLE ADD/MODIFY face a dilemma of implementing against the new framework but 
> lose backward consistency.
> Fully migrating to the new framework takes a lot of effort and maybe a 
> long-term plan, but at least it's the time to put it on the agenda to have a 
> track.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to