XComp commented on code in PR #20755:
URL: https://github.com/apache/flink/pull/20755#discussion_r1027502971
##########
flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java:
##########
@@ -82,13 +82,14 @@ public void testWriteFile() throws Exception {
DataStream<String> stream =
env.addSource(new FiniteTestSource<>(data),
TypeInformation.of(String.class));
Review Comment:
```suggestion
// FiniteTestSource causes two output files to be generated
downstream
env.addSource(new FiniteTestSource<>(data),
TypeInformation.of(String.class));
```
we want to move the comment about generating two output files to the code
line that's actually causing this behavior.
##########
flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java:
##########
@@ -82,13 +84,23 @@ public void testWriteFile() throws Exception {
DataStream<String> stream =
env.addSource(new FiniteTestSource<>(data),
TypeInformation.of(String.class));
Configuration configuration = new Configuration();
-
+ // Elements from source assign to one bucket , and produce two part
after checkpoint.
Review Comment:
Thanks for the clarification. In that case, we might want to move the second
part of the comment further up (see my related comment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
