JingsongLi commented on code in PR #388:
URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027644463
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java:
##########
@@ -130,4 +119,42 @@ public SplitEnumerator<FileStoreSourceSplit,
PendingSplitsCheckpoint> restoreEnu
return new StaticFileStoreSplitEnumerator(context, snapshot,
splits);
}
}
+
+ private DataFilePlan batchScanSplits(DataTableScan scan) {
+ return scan.plan();
+ }
+
+ private DataFilePlan continuousFirstScanSplits(
+ DataTableScan scan, SnapshotManager snapshotManager) {
+ switch (startupMode) {
+ case FULL:
+ DataFilePlan plan;
+ if (table.options().changelogProducer()
+ == CoreOptions.ChangelogProducer.FULL_COMPACTION) {
+ // Read the results of the last full compaction.
+ // Only full compaction results will appear on the max
level.
+ plan = scan.withLevel(table.options().numLevels() -
1).plan();
+ } else {
+ plan = scan.plan();
+ }
+ return plan;
+ case LATEST:
+ return new DataFilePlan(
+ snapshotManager.latestSnapshotId(),
Collections.emptyList());
+ case FROM_TIMESTAMP:
Review Comment:
Good point, I think we can improve this later, because now we can not unset
option in Flink SQL, we can wait for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
