hlteoh37 commented on code in PR #15:
URL:
https://github.com/apache/flink-connector-aws/pull/15#discussion_r1029078032
##########
flink-sql-connector-dynamodb/pom.xml:
##########
@@ -77,6 +77,7 @@ under the License.
<include>org.apache.httpcomponents:*</include>
<include>io.netty:*</include>
<include>commons-logging:commons-logging</include>
+
<include>commons-codec:commons-codec</include>
Review Comment:
Good spot. Updated notice file
Used the following output from build
1.15.2
```
[INFO] --- maven-shade-plugin:3.2.4:shade (shade-flink) @
flink-sql-connector-dynamodb ---
[INFO] Including
org.apache.flink:flink-connector-dynamodb:jar:1.0.0-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-base:jar:1.15.2 in the
shaded jar.
[INFO] Including org.apache.flink:flink-connector-aws-base:jar:1.15.2 in the
shaded jar.
[INFO] Including software.amazon.awssdk:netty-nio-client:jar:2.17.247 in the
shaded jar.
[INFO] Including io.netty:netty-codec-http:jar:4.1.77.Final in the shaded
jar.
[INFO] Including io.netty:netty-codec-http2:jar:4.1.77.Final in the shaded
jar.
[INFO] Including io.netty:netty-codec:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-transport:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-common:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-buffer:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-handler:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-classes-epoll:jar:4.1.77.Final in
the shaded jar.
[INFO] Including
io.netty:netty-transport-native-unix-common:jar:4.1.77.Final in the shaded jar.
[INFO] Including org.reactivestreams:reactive-streams:jar:1.0.3 in the
shaded jar.
[INFO] Including software.amazon.awssdk:sts:jar:2.17.247 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-query-protocol:jar:2.17.247 in
the shaded jar.
[INFO] Including software.amazon.awssdk:dynamodb:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:aws-json-protocol:jar:2.17.247 in
the shaded jar.
[INFO] Including
software.amazon.awssdk:third-party-jackson-core:jar:2.17.247 in the shaded jar.
[INFO] Including software.amazon.awssdk:json-utils:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:protocol-core:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:profiles:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:sdk-core:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:auth:jar:2.17.247 in the shaded jar.
[INFO] Including software.amazon.awssdk:http-client-spi:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:regions:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:annotations:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:utils:jar:2.17.247 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-core:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:metrics-spi:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:apache-client:jar:2.17.247 in the
shaded jar.
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.13 in the
shaded jar.
[INFO] Including commons-logging:commons-logging:jar:1.2 in the shaded jar.
[INFO] Including commons-codec:commons-codec:jar:1.11 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.13 in the shaded
jar.
[INFO] Including software.amazon.awssdk:dynamodb-enhanced:jar:2.17.247 in
the shaded jar.
[INFO] Excluding software.amazon.eventstream:eventstream:jar:1.0.1 from the
shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-force-shading:jar:16.0 from
the shaded jar.
[INFO] Excluding org.slf4j:slf4j-api:jar:1.7.36 from the shaded jar.
[INFO] No artifact matching filter io.netty:netty
```
1.16.0
```
[INFO] --- maven-shade-plugin:3.2.4:shade (shade-flink) @
flink-sql-connector-dynamodb ---
[INFO] Including
org.apache.flink:flink-connector-dynamodb:jar:1.0.0-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-base:jar:1.16.0 in the
shaded jar.
[INFO] Including org.apache.flink:flink-connector-aws-base:jar:1.16.0 in the
shaded jar.
[INFO] Including software.amazon.awssdk:netty-nio-client:jar:2.17.247 in the
shaded jar.
[INFO] Including io.netty:netty-codec-http:jar:4.1.77.Final in the shaded
jar.
[INFO] Including io.netty:netty-codec-http2:jar:4.1.77.Final in the shaded
jar.
[INFO] Including io.netty:netty-codec:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-transport:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-common:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-buffer:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-handler:jar:4.1.77.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-classes-epoll:jar:4.1.77.Final in
the shaded jar.
[INFO] Including
io.netty:netty-transport-native-unix-common:jar:4.1.77.Final in the shaded jar.
[INFO] Including org.reactivestreams:reactive-streams:jar:1.0.3 in the
shaded jar.
[INFO] Including software.amazon.awssdk:sts:jar:2.17.247 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-query-protocol:jar:2.17.247 in
the shaded jar.
[INFO] Including software.amazon.awssdk:dynamodb:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:aws-json-protocol:jar:2.17.247 in
the shaded jar.
[INFO] Including
software.amazon.awssdk:third-party-jackson-core:jar:2.17.247 in the shaded jar.
[INFO] Including software.amazon.awssdk:json-utils:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:protocol-core:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:profiles:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:sdk-core:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:auth:jar:2.17.247 in the shaded jar.
[INFO] Including software.amazon.awssdk:http-client-spi:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:regions:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:annotations:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:utils:jar:2.17.247 in the shaded jar.
[INFO] Including software.amazon.awssdk:aws-core:jar:2.17.247 in the shaded
jar.
[INFO] Including software.amazon.awssdk:metrics-spi:jar:2.17.247 in the
shaded jar.
[INFO] Including software.amazon.awssdk:apache-client:jar:2.17.247 in the
shaded jar.
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.13 in the
shaded jar.
[INFO] Including commons-logging:commons-logging:jar:1.2 in the shaded jar.
[INFO] Including commons-codec:commons-codec:jar:1.11 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.13 in the shaded
jar.
[INFO] Including software.amazon.awssdk:dynamodb-enhanced:jar:2.17.247 in
the shaded jar.
[INFO] Excluding software.amazon.eventstream:eventstream:jar:1.0.1 from the
shaded jar.
[INFO] Excluding org.apache.flink:flink-shaded-force-shading:jar:16.0 from
the shaded jar.
[INFO] Excluding org.slf4j:slf4j-api:jar:1.7.36 from the shaded jar.
[INFO] No artifact matching filter io.netty:netty
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
