[
https://issues.apache.org/jira/browse/FLINK-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637259#comment-17637259
]
Weijie Guo commented on FLINK-28326:
------------------------------------
[~renqs] Sorry for the reply. I checked the code path and reproduced it
locally. Through the previous fix, we can ensure that the request thread must
be blocked before the main thread recycle the buffer. However, there is still
an extreme case where the request thread recovers from blocking very quickly,
resulting in a calculated back-pressure time is equal to 0. I propose that we
can add a very short waiting time before `buffer.recycleBuffer` and I tested it
thousands of times locally, it seems that the problem did not recur.
> ResultPartitionTest.testIdleAndBackPressuredTime failed with AssertError
> ------------------------------------------------------------------------
>
> Key: FLINK-28326
> URL: https://issues.apache.org/jira/browse/FLINK-28326
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Network
> Affects Versions: 1.16.0
> Reporter: Huang Xingbo
> Assignee: Weijie Guo
> Priority: Major
> Labels: pull-request-available, stale-assigned, test-stability
> Fix For: 1.17.0
>
>
> {code:java}
> 2022-06-30T09:23:24.0469768Z Jun 30 09:23:24 [INFO]
> 2022-06-30T09:23:24.0470382Z Jun 30 09:23:24 [ERROR] Failures:
> 2022-06-30T09:23:24.0471581Z Jun 30 09:23:24 [ERROR]
> ResultPartitionTest.testIdleAndBackPressuredTime:414
> 2022-06-30T09:23:24.0472898Z Jun 30 09:23:24 Expected: a value greater than
> <0L>
> 2022-06-30T09:23:24.0474090Z Jun 30 09:23:24 but: <0L> was equal to <0L>
> {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=37406&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
