shuiqiangchen commented on code in PR #20745:
URL: https://github.com/apache/flink/pull/20745#discussion_r1030072896
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java:
##########
@@ -128,7 +129,9 @@ protected void perform(RelOptRuleCall call, Filter filter,
Join join) {
joinType,
true,
!joinType.generatesNullsOnLeft(),
- !joinType.generatesNullsOnRight(),
+ !joinType.generatesNullsOnRight()
+ &&
!TemporalJoinUtil.containsInitialTemporalJoinCondition(
Review Comment:
Thanks! I added a `FlinkJoinReduceExpressionsRule` based on
`JoinReduceExpressionsRule` as you suggested and skip the constant reduce when
it is a temporal join, it can solve the case.
And there is one more question that it seems processing time temporal is not
supported yet, do we only consider event time temporal join in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
