JingsongLi commented on code in PR #399:
URL: https://github.com/apache/flink-table-store/pull/399#discussion_r1030219825
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/FileStoreTableFactory.java:
##########
@@ -63,7 +62,7 @@ public static FileStoreTable create(
newOptions.set(PATH, tablePath.toString());
// validate merged options
- validateOptions(new CoreOptions(newOptions));
+ CoreOptions.validateTableOptions(tableSchema, new
CoreOptions(newOptions));
Review Comment:
We could validate new tableSchema. (It's down there)
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java:
##########
@@ -695,6 +691,44 @@ public InlineElement getDescription() {
}
}
+ /**
+ * Validate the {@link TableSchema} and {@link CoreOptions}.
+ *
+ * <p>TODO validate all items in schema and all keys in options.
+ *
+ * @param schema the schema to be validated
+ * @param options the options to be validated
+ */
+ public static void validateTableOptions(TableSchema schema, CoreOptions
options) {
Review Comment:
Minor: this options can generated by `schema`. Just
`validateTableOptions(TableSchema schema)` is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
