zentol commented on code in PR #21150:
URL: https://github.com/apache/flink/pull/21150#discussion_r1030315651


##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaConsumerThread.java:
##########
@@ -258,7 +259,7 @@ public void run() {
                 // over
                 if (records == null) {
                     try {
-                        records = consumer.poll(pollTimeout);
+                        records = 
consumer.poll(Duration.ofMillis(pollTimeout));

Review Comment:
   Please split the commits such that 1 is making the poll change, and the 
other (hotfix) commit with the remaining changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to