alpinegizmo commented on PR #21349:
URL: https://github.com/apache/flink/pull/21349#issuecomment-1325030716

   > > Some version of the explanation in this PR needs to put somewhere where 
flink developers can find it. Probably here: 
https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/flinkdev/building/#dependency-shading
   > 
   > That page is all about building Flink from source and the peculiarities 
about building Flink on Maven 3.3+ (which this PR should actually update!). 
It's not really developer documentation on how to setup shading (or really 
_changing_ Flink in any way) etc.
   > 
   > I'm inclined to add a page to the wiki / extend the 
[Dependencies](https://cwiki.apache.org/confluence/display/FLINK/Dependencies) 
page.
   
   That page in the docs on building Flink is in a section entitled "Flink 
Development", and building Flink from source is the first step toward 
contributing to Flink. Perhaps developer documentation doesn't belong here, but 
there should at least be a noticeable pointer to the wiki. I say this as 
someone who was, until quite recently, unaware that there is valuable content 
for contributors (other than the FLIPs) in the wiki.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to