[
https://issues.apache.org/jira/browse/FLINK-29906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637910#comment-17637910
]
Daren Wong commented on FLINK-29906:
------------------------------------
Hi [~chesnay], thank you, that's a very good point. Currently, dynamodb
connector parent pom is pointing to your repo "flink-connector-parent"
[https://github.com/zentol/flink-connector-parent/blob/master/pom.xml.|https://github.com/zentol/flink-connector-parent/blob/master/pom.xml]
I can create a PR to that pom.xml, but I am wondering if I should do it on your
repo or should it be in a "shared" flink-connector parent repo?
> Address tabs/spaces in checkstyle/spotless
> ------------------------------------------
>
> Key: FLINK-29906
> URL: https://issues.apache.org/jira/browse/FLINK-29906
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / AWS
> Reporter: Danny Cranmer
> Assignee: Daren Wong
> Priority: Major
> Labels: pull-request-available
> Fix For: aws-connector-2.0.0
>
>
> The DynamoDB connector has a mix of tabs and spaces, the quality config does
> not seem to be enforcing anything. The code style guide says we should [use
> spaces|https://flink.apache.org/contributing/code-style-and-quality-formatting.html#whitespaces].
> - Update code to use spaces
> - Fix quality plugin to reject tabs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
