liuml07 opened a new pull request, #21379:
URL: https://github.com/apache/flink/pull/21379
## What is the purpose of the change
Stop stringifying exception for logging
## Brief change log
In org.apache.flink.runtime.taskmanager.Task there are multiple places where
we stringify an exception before logging. According to Slf4j logging, we can
just leave the last argument as exception (or throwable) without fitting them
into log message string with placeholders.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
I wrote following code and the two print the same exception:
```java
Exception e = new CompletionException("a", new FlinkException("b", new
Exception("c")));
Task.LOG.error("luck number {}", 2022, e); // 1
e.printStackTrace(); // 2
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ **not** documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
