JingsongLi commented on code in PR #403:
URL: https://github.com/apache/flink-table-store/pull/403#discussion_r1033075278
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/RecordWriter.java:
##########
@@ -34,10 +34,12 @@
void write(T record) throws Exception;
/**
- * Compact all files related to the writer. Note that compaction process
is only submitted and
- * may not be completed when the method returns.
+ * Compact files related to the writer. Note that compaction process is
only submitted and may
+ * not be completed when the method returns.
+ *
+ * @param fullCompaction whether to trigger full compaction or just normal
compaction
Review Comment:
I think there are two things:
- Is this compaction full or normal.
- Should we wait latest compaction.
I think we can separate these two things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
