eskabetxe commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1328802341
Hi @wanglijie95, 1- Im ok with introducing only non-xa sink in this PR, I will clean up the code.. 2- For what Im seeing we have the same problem with RuntimeContext, at open method (line 138), at line 144 is calling createAndOpenStatementExecutor, that internally do this "JdbcExec exec = statementExecutorFactory.apply(getRuntimeContext()); (line 170)", so we have the same problem Im afraid We could extract the common code to another class an use that on the two implementation what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
