reswqa commented on code in PR #21199:
URL: https://github.com/apache/flink/pull/21199#discussion_r1033351526
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/InputConsumableDecider.java:
##########
@@ -33,14 +33,14 @@ public interface InputConsumableDecider {
* Determining weather the input of an execution vertex is consumable.
*
* @param executionVertexID identifier of this {@link ExecutionVertex}.
- * @param verticesToDeploy all vertices to deploy during the current
scheduling process. This
- * set will be used to know whether an execution vertex has been
decided to scheduled.
+ * @param verticesToSchedule vertices that are not yet scheduled by
already decided to be
+ * scheduled.
* @param consumableStatusCache a cache for {@link ConsumedPartitionGroup}
consumable status.
- * This will be used to reduce double computing.
+ * This is to avoid repetitive computation.
*/
boolean isInputConsumable(
ExecutionVertexID executionVertexID,
- Set<ExecutionVertexID> verticesToDeploy,
+ Set<ExecutionVertexID> verticesToSchedule,
Review Comment:
Ah, I forgot to change it.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ConsumedPartitionGroup.java:
##########
@@ -132,4 +133,25 @@ public boolean areAllPartitionsFinished() {
public ResultPartitionType getResultPartitionType() {
return resultPartitionType;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ ConsumedPartitionGroup that = (ConsumedPartitionGroup) o;
+ return numConsumers == that.numConsumers
+ && Objects.equals(resultPartitions, that.resultPartitions)
+ && Objects.equals(intermediateDataSetID,
that.intermediateDataSetID)
+ && resultPartitionType == that.resultPartitionType;
+ }
Review Comment:
Make sense, fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
