zentol commented on code in PR #21387:
URL: https://github.com/apache/flink/pull/21387#discussion_r1033497947
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java:
##########
@@ -379,6 +379,7 @@ private static Optional<MetricReporter> loadReporter(
if (reporterClassName != null) {
LOG.warn(
"The reporter configuration of '{}' configures the
reporter class, which is a deprecated approach to configure reporters."
+ + " The used reporter might not even support
reflection-based instantiation, anymore, leading to unexpected errors."
Review Comment:
```suggestion
+ " The used reporter might not support this
configuration, which would result in the reporter not being loaded."
```
- anymore: There may be reporters that never supported this in the first
place.
- reflection-base instantiation: relatively technical description
- unexpected errors: they are kinda expected :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
