lindong28 opened a new pull request, #184:
URL: https://github.com/apache/flink-ml/pull/184

   ## What is the purpose of the change
   
   All python tests are currently run with execution.attached=false by default. 
Thus `env.execute()` can return result before the execution finishes. This 
means that tests such as `RobustScalerTest::test_save_load_predict()` can start 
one job before the previous job finishes, with both jobs executed using the 
same StreamExecutionEnvironment instance.
   
   Currently StreamExecutionEnvironment is not thread-safe and it might fail if 
it is used in the manner described above. This PR sets execution.attached=True 
for all python tests so that `env.execute()` will only return after the job 
finishes.
   
   ## Brief change log
   
   Updates `PyFlinkMLTestCase` to configure StreamExecutionEnvironment with 
execution.attached=True.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to