XComp commented on code in PR #21387:
URL: https://github.com/apache/flink/pull/21387#discussion_r1033564067
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java:
##########
@@ -379,6 +379,7 @@ private static Optional<MetricReporter> loadReporter(
if (reporterClassName != null) {
LOG.warn(
"The reporter configuration of '{}' configures the
reporter class, which is a deprecated approach to configure reporters."
+ + " The used reporter might not even support
reflection-based instantiation, anymore, leading to unexpected errors."
Review Comment:
I force-pushed a slightly different version. I don't like the `which would
result in the reporter not being loaded` since it implies that things might
still work (just with the reporter not being available). I would rather point
out that errors might be the result of the reporter not supporting the config
anymore...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
