Zakelly commented on code in PR #21362:
URL: https://github.com/apache/flink/pull/21362#discussion_r1034413200
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java:
##########
@@ -72,6 +73,10 @@ public void setCurrentKey(@Nonnull K currentKey) {
@Override
public void setCurrentKeyGroupIndex(int currentKeyGroupIndex) {
+ if (!keyGroupRange.contains(currentKeyGroupIndex)) {
+ throw KeyGroupRangeOffsets.newIllegalKeyGroupException(
+ currentKeyGroupIndex, keyGroupRange);
+ }
Review Comment:
> How about the opposite: removing the check from HashMapStateBackend
(StateTable) and relying on `InternalKeyContext`? So that it works for any
backend. As a side benefit, that would be a bit faster because the check would
be done once per input record, not per state access.
I Agree. That's what I'm trying to say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
