[ 
https://issues.apache.org/jira/browse/FLINK-30052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640506#comment-17640506
 ] 

Mason Chen commented on FLINK-30052:
------------------------------------

[~martijnvisser] I started this task over the weekend. There were some issues 
in porting the Kafka related E2E tests over, using 1.17-SNAPSHOT for the Flink 
version, since the snapshot artifacts do not exist for flink-sql-client-test 
[1] and flink-end-to-end-tests-common [2]. [1] is built at build time using the 
`maven-dependency-plugin`.

 

I suspect that [1] is something that the other connectors will face and can be 
solved commonly. With regards to flink-to-end-tests-common, should a snapshot 
be published here: 
[https://repository.apache.org/content/groups/snapshots/org/apache/flink/]? 

 

Elasticsearch E2E tests fortunately didn't have these dependencies but other 
connectors do.

 

Also, due to the changes in 1.17 (split level watermark alignment), it isn't 
straightforward to downgrade the master code to 1.16, so I will need to repeat 
the externalization instructions for master branch, release-1.16 branch, etc.

 

[1] 
[https://github.com/apache/flink/blob/bee3e9442fa2749f0b2e21d79949b5410fa422e5/flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml#L196]

[2] 
[https://github.com/apache/flink/blob/bee3e9442fa2749f0b2e21d79949b5410fa422e5/flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml#L43]

> Move existing Kafka connector code from Flink repo to dedicated Kafka repo
> --------------------------------------------------------------------------
>
>                 Key: FLINK-30052
>                 URL: https://issues.apache.org/jira/browse/FLINK-30052
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Connectors / Kafka
>            Reporter: Martijn Visser
>            Assignee: Mason Chen
>            Priority: Major
>
> Instructions guide can be found at 
> https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to