XComp commented on code in PR #21418:
URL: https://github.com/apache/flink/pull/21418#discussion_r1034696632
##########
flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh:
##########
@@ -113,7 +113,6 @@ function run_ha_test() {
# jm killing loop
set_config_key "env.pid.dir" "${TEST_DATA_DIR}"
- setup_flink_shaded_zookeeper ${ZOOKEEPER_VERSION}
Review Comment:
Is there a reason to keep `${ZOOKEEPER_VERSION}` as a parameter in this
method? It's not really needed anymore analogously to the other files where we
reverted mentioning the ZK version in the log output.
##########
flink-end-to-end-tests/test-scripts/test_ha_per_job_cluster_datastream.sh:
##########
@@ -113,7 +113,6 @@ function run_ha_test() {
# jm killing loop
set_config_key "env.pid.dir" "${TEST_DATA_DIR}"
- setup_flink_shaded_zookeeper ${ZOOKEEPER_VERSION}
Review Comment:
We're even removing the ZK version in `run-nightly-tests.sh` as a parameter
of `test_ha_per_job_cluster_datastream.sh`. So, I guess, we can clean it up
entirely here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
