luoyuxia commented on code in PR #20016:
URL: https://github.com/apache/flink/pull/20016#discussion_r1036655683
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java:
##########
@@ -257,6 +279,12 @@ public void applyProjection(int[][] projectedFields,
DataType producedDataType)
this.projectedFields = Arrays.stream(projectedFields).mapToInt(value
-> value[0]).toArray();
}
+ @Override
+ public Result applyFilters(List<ResolvedExpression> filters) {
+ this.filters = new ArrayList<>(filters);
+ return Result.of(new ArrayList<>(filters), new ArrayList<>(filters));
Review Comment:
What if the underlying format is text? If we remove it from the original
filters, it will bring wrong result since text format don't support filter
pushdown . The hard is we can't know what's the underlying format in plan phase
currently though we can propose some new interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
