morhidi commented on code in PR #420:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1033671472
##########
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##########
@@ -79,7 +79,9 @@ spec:
{{- end }}
env:
- name: OPERATOR_NAMESPACE
Review Comment:
Sorry, I forgot to submit this comment, I'm trying to understand why we need
to change this part from:
```
- name: OPERATOR_NAMESPACE
value: {{ .Release.Namespace }}
```
to
```
- name: OPERATOR_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
```
It doesn't seem to be related to the watch namespaces, otherwise the changes
are good.
##########
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##########
@@ -79,7 +79,9 @@ spec:
{{- end }}
env:
- name: OPERATOR_NAMESPACE
Review Comment:
@jbusche @tagarr ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
