JingsongLi commented on code in PR #416:
URL: https://github.com/apache/flink-table-store/pull/416#discussion_r1039087564
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/AbstractFileStoreTable.java:
##########
@@ -40,6 +47,43 @@ public AbstractFileStoreTable(Path path, TableSchema
tableSchema) {
protected abstract FileStore<?> store();
+ protected abstract FileStoreTable copy(TableSchema newTableSchema);
+
+ @Override
+ public FileStoreTable copy(Map<String, String> dynamicOptions) {
+ // check option is not immutable
+ Map<String, String> options = tableSchema.options();
+ dynamicOptions.forEach(
+ (k, v) -> {
+ if (!Objects.equals(v, options.get(k))) {
Review Comment:
The immutable field may be exist in the dynamic parameters.
For example, for Flink, Flink planner just pass a options merged table
options and dynamic options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
