wanglijie95 commented on code in PR #21388:
URL: https://github.com/apache/flink/pull/21388#discussion_r1043259143
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/EdgeManagerBuildUtil.java:
##########
@@ -197,10 +202,22 @@ private static ConsumedPartitionGroup
createAndRegisterConsumedPartitionGroupToE
ConsumedPartitionGroup consumedPartitionGroup =
ConsumedPartitionGroup.fromMultiplePartitions(
numConsumers, consumedPartitions,
intermediateResult.getResultType());
+ finishConsumablePartitions(intermediateResult, consumedPartitions,
consumedPartitionGroup);
registerConsumedPartitionGroupToEdgeManager(consumedPartitionGroup,
intermediateResult);
return consumedPartitionGroup;
}
+ private static void finishConsumablePartitions(
+ IntermediateResult intermediateResult,
+ List<IntermediateResultPartitionID> consumedPartitionId,
+ ConsumedPartitionGroup consumedPartitionGroup) {
+ for (IntermediateResultPartitionID intermediateResultPartitionID :
consumedPartitionId) {
+ if
(intermediateResult.getPartitionById(intermediateResultPartitionID).isConsumable())
{
Review Comment:
I suggest that the condition be changed to `isBlocking && isConsumable`(Or
make the`isBlocking` judgment outside the loop).
IMO, `CONSUMABLE` is not not exactly equivalent to `FINISHED`( I think
FINSIHED = BLOCKING + CONSUMABLE, although in the current implementation it is
true that only the blocking edge can be CONSUMABLE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
