zentol commented on code in PR #21477:
URL: https://github.com/apache/flink/pull/21477#discussion_r1044418411


##########
flink-dist/pom.xml:
##########
@@ -688,9 +688,7 @@ under the License.
                                        </execution>
                                        <execution>
                                                <!--
-                                               Disable inherited shade-flink 
to prevent the Shade plugin from changing the project.basedir. The basedir
-                                               is changed by the Shade plugin 
when dependencyReducedPomLocation is set to a different location than the
-                                               original basedir. We do that in 
the root pom.xml.
+                                               Historic artifact; shade-dist 
execution should be renamed.

Review Comment:
   This is something for a follow-up since it also affects other components 
(like the license checker)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to