SmirAlex commented on code in PR #20919:
URL: https://github.com/apache/flink/pull/20919#discussion_r1044681283
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/CacheLoader.java:
##########
@@ -59,11 +65,11 @@ public abstract class CacheLoader extends
AbstractRichFunction implements Runnab
protected volatile boolean isStopped;
- protected abstract void reloadCache() throws Exception;
+ protected abstract void updateCache() throws Exception;
- @Override
public void open(Configuration parameters) throws Exception {
firstLoadLatch = new CountDownLatch(1);
+ reloadExecutor = Executors.newSingleThreadExecutor();
}
public void open(CacheMetricGroup cacheMetricGroup) {
Review Comment:
Agree, fixed. Btw you are right, naming was initially came from
`LookupCache#open`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
