SmirAlex commented on PR #20919: URL: https://github.com/apache/flink/pull/20919#issuecomment-1344609982
> After some offline chat with @zentol about it, I came to the conclusion that it's really not the right location for such a big change. We should focus on stabilizing the test here. I moved my proposal into [FLINK-30354](https://issues.apache.org/jira/browse/FLINK-30354). I will do another review of this PR on Monday. Yea, I think this MR is already a little bit blowed up, so such big changes should be in separate ticket. About your proposal: I like the idea of reusing the same thread pool, and especially, clarifying the logic of `CacheLoader`, so it won't deal with interrupts. But I'm not sure about changing `CacheReloadTrigger`s and `CacheReloadTrigger.Context`, because it touches already public API (although added relatively recently). BTW during the [FLIP-221 ](https://cwiki.apache.org/confluence/display/FLINK/FLIP-221:+Abstraction+for+lookup+source+cache+and+metric) development I discussed the design with @PatrickRen and @wuchong. So I think it would be good if they also take a look at your proposal in [FLINK-30354](https://issues.apache.org/jira/browse/FLINK-30354) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
