fredia commented on PR #21405: URL: https://github.com/apache/flink/pull/21405#issuecomment-1345160608
@rkhachatryan Thanks for reviewing. > 1. Have you considered splitting StateChange class into StateChange and StateChange? I splited the constructor of StateChange into `StateChange(byte[])` and `StateChange(int keyGroup, byte[])`, as you suggested, I add `ofMetadataChange(byte[])` and `ofDataChange(int keyGroup, byte[]))` factory methods. > 2. In [StateChangeFormat.writeChangeSet](https://github.com/apache/flink/blob/master/flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFormat.java#L66), the metadata can now be written out explicitly, rather than relying on sorting. 👍Good catch, this can avoid the overhead of sorting, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
