snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1047264081
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -428,13 +434,13 @@ private void createTestTopic(String topic, int
numPartitions, short replicationF
admin.createTopics(
Collections.singletonList(
new NewTopic(topic, numPartitions,
replicationFactor)));
- result.all().get();
+ result.all().get(1, TimeUnit.MINUTES);
Review Comment:
why do we need this change?
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -428,13 +434,13 @@ private void createTestTopic(String topic, int
numPartitions, short replicationF
admin.createTopics(
Collections.singletonList(
new NewTopic(topic, numPartitions,
replicationFactor)));
- result.all().get();
+ result.all().get(1, TimeUnit.MINUTES);
}
private void deleteTestTopic(String topic)
throws ExecutionException, InterruptedException, TimeoutException {
final DeleteTopicsResult result =
admin.deleteTopics(Collections.singletonList(topic));
- result.all().get();
+ result.all().get(1, TimeUnit.MINUTES);
Review Comment:
why do we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
