gaborgsomogyi commented on code in PR #21511:
URL: https://github.com/apache/flink/pull/21511#discussion_r1049365162
##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/NoOpDelegationTokenManager.java:
##########
@@ -35,12 +34,12 @@ public NoOpDelegationTokenManager() {
}
@Override
- public void obtainDelegationTokens(Credentials credentials) {
+ public void obtainDelegationTokens(DelegationTokenContainer container) {
LOG.debug("obtainDelegationTokens");
}
@Override
- public void start(DelegationTokenListener delegationTokenListener) {
+ public void start(Listener listener) {
Review Comment:
I think yes, because null checks cost more in code than a noop manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
