1996fanrui commented on PR #21447: URL: https://github.com/apache/flink/pull/21447#issuecomment-1354154092
> In the first step, we do not touch how thread samples are captured / cached, and only provide apis for building flame graph with samples from a specific subtask. This should be good enough for addressing the original demand, which is to provide drill-down visualizations for the operator-level flame graph. Do you mean that we get the result of subtask level from job-vertex-cache in the first step, right? And don't trigger any thread sampling when get the result of subtask level, right? > I think the order doesn't really matter. Checking the job-vertex cache first would allow us to access the execution-vertex cache with a simple computeIfAbsent-style logic. But that depends on the detailed implementation. In the second step, we get the result of subtask level from `job-vertex cache` and `execution-vertex cache`, and choose the newer one, right? And trigger the subtask thread sampling when the `execution-vertex cache` is empty or stale, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
