MartijnVisser commented on PR #21128:
URL: https://github.com/apache/flink/pull/21128#issuecomment-1355010072

   > @MartijnVisser I would say we have similar issue locally w/o this change 
and if you see the same + considering the fact that the tests are passing on CI 
then I would merge it. @zentol WDYT?
   
   @gaborgsomogyi I'm not too big of a fan, especially without not being able 
to run the Hadoop3 tests. I'm doing the following right now (with the latest 
push)
   
   1. I've found two more issues in the current PR that I've fixed (for which I 
downgraded beanutils for `flink-yarn` and one more occurrence where I could 
introduce `GenericTestUtils`). Next to that, I've rebased and pushed these 
changes. So let's see if the CI (still) passes
   2. In a separate push to another branch, I've changed the current Azure CI 
scripts to run the Hadoop3 tests instead of the Hadoop2 ones. That will run on 
https://dev.azure.com/martijn0323/Flink/_build/results?buildId=3773&view=results
 
   
   If the CI of both step 1 and step 2 still pass, then I think we can safely 
merge it. If not, then we need to figure out what we're doing wrong 😅 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to