Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/2453
  
    Thanks for the nice contribution.
    
    I see one minor detail that could cause problems. Even if we do not 
register the `CheckpointCoordinator` as `JobStatusListener`, it might still be 
possible that `triggerCheckpoint(long timestamp, CheckpointProperties props)` 
gets called. In this case it can happen that a periodic trigger is registered. 
You could introduce another check on the interval to make sure that no periodic 
trigger can be registered when the CheckpointCoordinator is disabled.
    
    Besides that, the changes look good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to