Myracle commented on code in PR #21347:
URL: https://github.com/apache/flink/pull/21347#discussion_r1053283384
##########
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java:
##########
@@ -1344,6 +1344,13 @@ public CompletableFuture<Set<AbstractID>>
listCompletedClusterDatasetIds() {
metaInfoMap -> new
HashSet<>(metaInfoMap.keySet())));
}
+ public CompletableFuture<Void> reportHeartbeat(JobID jobId, long
expiredTimestamp) {
+ return runDispatcherCommand(
+ dispatcherGateway ->
+ dispatcherGateway.reportJobClientHeartbeat(
+ jobId, expiredTimestamp, rpcTimeout));
+ }
Review Comment:
The client's heartbeat will only be sent when the configs execution.attached
and execution.shutdown-on-attached-exit are both true. So it is not used in
MiniCluster at most time. It's easier to write tests in this way. Also, we can
keep consistent with other cluster modes. Do you still think that we should
remove it in mimi cluster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
