dmvk commented on code in PR #21537:
URL: https://github.com/apache/flink/pull/21537#discussion_r1053371931
##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionServiceTest.java:
##########
@@ -321,27 +366,29 @@ SimpleTestingLeaderElectionEventListener
getLeaderElectionEventListener() {
private static final class SimpleTestingLeaderElectionEventListener
implements LeaderElectionEventHandler {
- private boolean hasLeadership;
+ // is set if the current LeaderElection client is select as the leader
by the HA backend
+ @Nullable private UUID currentLeaderSessionId;
+ // is set if the leader information in the HA backend changes
Review Comment:
nit
```suggestion
/** is set if the leader information in the HA backend changes */
```
##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultMultipleComponentLeaderElectionServiceTest.java:
##########
@@ -321,27 +366,29 @@ SimpleTestingLeaderElectionEventListener
getLeaderElectionEventListener() {
private static final class SimpleTestingLeaderElectionEventListener
implements LeaderElectionEventHandler {
- private boolean hasLeadership;
+ // is set if the current LeaderElection client is select as the leader
by the HA backend
Review Comment:
nit
```suggestion
/** is set if the current LeaderElection client is select as the
leader by the HA backend */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
