MartijnVisser commented on code in PR #48:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/48#discussion_r1053381784
##########
flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSinkITCase.java:
##########
@@ -65,13 +65,20 @@
import static
org.apache.flink.streaming.connectors.elasticsearch.table.TestContext.context;
import static org.apache.flink.table.api.Expressions.row;
import static org.assertj.core.api.Assertions.assertThat;
+import static org.testcontainers.containers.wait.strategy.Wait.forHttp;
/** IT tests for {@link Elasticsearch6DynamicSink}. */
public class Elasticsearch6DynamicSinkITCase extends TestLogger {
@ClassRule
public static ElasticsearchContainer elasticsearchContainer =
- new
ElasticsearchContainer(DockerImageName.parse(DockerImageVersions.ELASTICSEARCH_6));
+ new
ElasticsearchContainer(DockerImageName.parse(DockerImageVersions.ELASTICSEARCH_6))
+ .waitingFor(
+ forHttp("/")
+ .withMethod("HEAD")
+ .forStatusCode(200)
+ .forPort(9200)
+
.withStartupTimeout(Duration.ofMinutes(5)));
Review Comment:
Can you please set this to two minutes, like we've also done for other tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
