gyfora commented on code in PR #492:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/492#discussion_r1053501498
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java:
##########
@@ -121,13 +122,22 @@ public boolean scaleResource(
private boolean stabilizationPeriodPassed(
AbstractFlinkResource<?, ?> resource, Configuration conf) {
- var now = clock.instant();
+ var jobStatus = resource.getStatus().getJobStatus();
+
+ if (!JobStatus.RUNNING.name().equals(jobStatus.getState())) {
Review Comment:
This might be a redundant check because the `JobAutoscaler` class already
runs this check before calling any collection, evaluation etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
