tsreaper commented on code in PR #410: URL: https://github.com/apache/flink-table-store/pull/410#discussion_r1055030061
########## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/source/snapshot/ContinuousFromSnapshotStartingScanner.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.store.table.source.snapshot; + +import org.apache.flink.table.store.file.utils.SnapshotManager; +import org.apache.flink.table.store.table.source.DataTableScan; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Collections; + +/** + * {@link StartingScanner} for the {@link + * org.apache.flink.table.store.CoreOptions.StartupMode#FROM_SNAPSHOT} startup mode of a streaming + * read. + */ +public class ContinuousFromSnapshotStartingScanner implements StartingScanner { + + private static final Logger LOG = + LoggerFactory.getLogger(ContinuousFromTimestampStartingScanner.class); + + private final long snapshotId; + + public ContinuousFromSnapshotStartingScanner(long snapshotId) { + this.snapshotId = snapshotId; + } + + @Override + public DataTableScan.DataFilePlan getPlan(SnapshotManager snapshotManager, DataTableScan scan) { + return new DataTableScan.DataFilePlan(snapshotId, Collections.emptyList()); Review Comment: `from-timestamp` includes the changes at that timestamp, but `from-snapshot` does not include the changes at that snapshot? Why do you choose this behavior, please clarify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
