[
https://issues.apache.org/jira/browse/FLINK-30443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651302#comment-17651302
]
Robert Metzger commented on FLINK-30443:
----------------------------------------
I suggest to merge this as-is, and file a follow up ticket for making it
configurable.
This will allow us to collect feedback on the ticket.
At my current company, we had to make this change in our internal fork to
extend the list of sensitive keys. If this was configurable, it would have been
easier for us ... so I see benefits here.
In addition to that, our configuration page distinguishes between normal and
"advanced" configuration keys...and this is certainly an advanced configuration.
> Expand list of sensitive keys
> -----------------------------
>
> Key: FLINK-30443
> URL: https://issues.apache.org/jira/browse/FLINK-30443
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
> Reporter: Gunnar Morling
> Priority: Major
> Labels: pull-request-available
>
> In {{{}GlobalConfiguration{}}}, there is [a list of known configuration
> keys|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java#L47-L48]
> whose values will be masked in log output. In our Flink deployment there's a
> few more keys which we would like to mask, specifically, the following ones:
> * "auth-params"
> * "service-key"
> * "token"
> * "basic-auth"
> * "jaas.config"
> While those are somewhat use-case specific, I feel they are generic enough
> for being added to that list, and there already is precedence in form of
> "fs.azure.account.key". In that light, I don't think it's worth making this
> somehow pluggable, but I'm curious what other folks here think. Thanks!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
