zhuzhurk commented on code in PR #21464:
URL: https://github.com/apache/flink/pull/21464#discussion_r1057088280
##########
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java:
##########
@@ -289,6 +290,20 @@ public void signalNoMoreSplits(int subtask) {
"Failed to send 'NoMoreSplits' to reader " + subtask);
}
+ @Override
+ public void signalIntermediateNoMoreSplits(int subtask) {
+ checkSubtaskIndex(subtask);
+
+ // It's an intermediate noMoreSplit event, notify subtask to deal with
this event.
+ callInCoordinatorThread(
+ () -> {
+ subtaskHasNoMoreSplits[subtask] = false;
Review Comment:
In my understanding, it should be `false` initially and set to `true` when
on `signalNoMoreSplits(int)`. When failover happens, the value will be reset to
`false`. Seems there is no need for `signalIntermediateNoMoreSplits(int)` to do
the reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
